Skip to content

misc: fix spelling #8272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jbampton wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

misc: fix spelling #8272

jbampton wants to merge 5 commits into from
+283 −283

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Nov 27, 2023

Description

This PR fixes spelling

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

❌ Patch coverage is 24.63768% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.46%. Comparing base (9773ba3) to head (4a149f4).
⚠️ Report is 1919 commits behind head on main.

Files with missing lines Patch % Lines
.../xenserver/resource/XenServerStorageProcessor.java 0.00% 7 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 4 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 0.00% 3 Missing ⚠️
...ypervisor/ovm3/resources/Ovm3StorageProcessor.java 0.00% 3 Missing ⚠️
...e/resource/StorageSubsystemCommandHandlerBase.java 50.00% 1 Missing and 1 partial ⚠️
...oud/hypervisor/kvm/storage/KVMStorageResource.java 0.00% 2 Missing ⚠️
...e/cloudstack/network/guru/SspGuestNetworkGuru.java 0.00% 2 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 2 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 0.00% 2 Missing ⚠️
ui/src/views/offering/AddComputeOffering.vue 0.00% 2 Missing ⚠️
... and 23 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #8272      +/-   ##
============================================
- Coverage     29.20%   28.46%   -0.75%     
+ Complexity    31401    30456     -945     
============================================
  Files          5260     5260              
  Lines        369710   369710              
  Branches      53890    53890              
============================================
- Hits         107977   105229    -2748     
- Misses       246955   249948    +2993     
+ Partials      14778    14533     -245
Flag Coverage Δ
simulator-marvin-tests 24.07% <19.35%> (-0.97%) ⬇️
uitests 4.42% <0.00%> (ø)
unit-tests 14.99% <11.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jbampton
Copy link
Member Author

jbampton commented Nov 27, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 27, 2023

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 27, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7843

@shwstppr
Copy link
Contributor

shwstppr commented Nov 28, 2023

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 28, 2023

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland
DaanHoogland reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing only good language corrections here but I have two issues with the change as a whole:

  1. I see some corrections in commented and possibly dead code. Those should be handled by removing them
  2. I see some variable on interfaces of the system, that might give unexpected results either during or after upgrades. I'd like to see those extracted to separate commits, to facilitate testing and trouble shooting.

@blueorangutan
Copy link

blueorangutan commented Nov 28, 2023

[SF] Trillian test result (tid-8405)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46063 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8272-t8405-kvm-centos7.zip
Smoke tests completed. 117 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_upgrade_kubernetes_cluster Failure 560.41 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 613.46 test_kubernetes_clusters.py

@DaanHoogland DaanHoogland reopened this Nov 29, 2023
@github-actions
Copy link

github-actions bot commented Dec 7, 2023

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@jbampton jbampton marked this pull request as draft January 10, 2024 11:22
@github-actions
Copy link

github-actions bot commented Feb 8, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Dec 31, 2024

@jbampton , is this one still valid (or worth splitting up in smaller PRs)?

@jbampton
Copy link
Member Author

jbampton commented Dec 31, 2024

@jbampton , is this one still valid (or worth splitting up in smaller PRs)?

Hey @DaanHoogland I think some of this is still valid but marked as draft now.

Want to get #9132 merged first before this one. But true seems there are a lot of conflicts.

Need address the "ID" problem in #9132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

Assignees

No one assigned

Labels

component:api component:compute component:database component:hyperv component:kvm component:orchestration component:storage status:has-conflicts status:needs-work status:on-hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbampton @blueorangutan @shwstppr @DaanHoogland